Code smell: long, procedural background jobs (and how to fix it)

07/11/2020
1.686

I’ve worked on a handful of Rails applications that have pretty decent test coverage in terms of model specs and feature specs but are lacking in tests for background jobs. It seems that developers often find background jobs more difficult to test than Active Record models—otherwise the test coverage would presumably be better in that area. I’ve found background jobs of 100 lines in length with no tests, even though the same application’s Active Record models had pretty good test coverage.Apparently the background job code is somehow viewed as “separate” from the application code. For some reason the background job code doesn’t get tests, and for some reason the background job code doesn’t have an object-oriented structure like the rest of the application.Whatever the root cause of this issue, the fix is fortunately often pretty simple. We can apply the extract class refactoring technique to turn the long procedure background job into one or more neatly abstracted classes.
Code smell: long, procedural background jobs (and how to fix it) #ruby #rubydeveloper #rubyonrails #code https://rubyonrails.ba/single/code-smell-long-procedural-background-jobs-and-how-to-fix-it